Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 8.1 versions for Fedora and RHEL9 #393

Merged
merged 7 commits into from
Mar 9, 2023
Merged

Conversation

pkubatrh
Copy link
Member

@pkubatrh pkubatrh commented Jan 27, 2023

Resolves: #374

@pkubatrh
Copy link
Member Author

[test-all]

@pkubatrh
Copy link
Member Author

[test-all]

@pkubatrh
Copy link
Member Author

[test-all]

@pkubatrh
Copy link
Member Author

[test-all]

4 similar comments
@pkubatrh
Copy link
Member Author

pkubatrh commented Feb 1, 2023

[test-all]

@pkubatrh
Copy link
Member Author

pkubatrh commented Feb 2, 2023

[test-all]

@pkubatrh
Copy link
Member Author

pkubatrh commented Feb 3, 2023

[test-all]

@phracek
Copy link
Member

phracek commented Feb 6, 2023

[test-all]

@phracek
Copy link
Member

phracek commented Feb 7, 2023

Let's try it once more time. The subscription account should be now fixed.

[test-all]

8.1/Dockerfile.c9s Outdated Show resolved Hide resolved
8.1/Dockerfile.rhel8 Outdated Show resolved Hide resolved
8.1/content_sets.yml Outdated Show resolved Hide resolved
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues, which I have hit during the review.
Why do we have 8.1/.exclude-c9s file and 8.1/Dockerfile.c9s In case it is UBI based, then the Dockerfile and exclude file is not needed. This is a duplicity of Dockerfile.rhel9 which can be downloaded as UBI image.

@pkubatrh
Copy link
Member Author

pkubatrh commented Feb 9, 2023

[test-all]

@olstjos
Copy link

olstjos commented Feb 22, 2023

We're needing this still, what is remaining to do before this can pass tests and get merged?

@olstjos
Copy link

olstjos commented Feb 22, 2023

We're using OpenShift
http://artifacts.osci.redhat.com/testing-farm/f91ba16d-8209-42bd-90af-696344d26a21/ this artifact is not visible to the public, I think it's internal to Red Hat.
I am unable to look at the artifact so I can't even guess what the issue might be.

@phracek
Copy link
Member

phracek commented Mar 9, 2023

[test-openshift]

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some nitpicks.

LGTM. Thanks. Let's wait for the tests.

8.1/Dockerfile.fedora Outdated Show resolved Hide resolved
8.1/Dockerfile.fedora Show resolved Hide resolved
@pkubatrh
Copy link
Member Author

pkubatrh commented Mar 9, 2023

[test-all]

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding new PHP version.

Let's wait whether container tests are passing. If so, then let's get merge it.

@phracek phracek merged commit c9bed2c into sclorg:master Mar 9, 2023
@olstjos
Copy link

olstjos commented Mar 15, 2023

Ok so I've tested this 8.1, and have found the following:

Our secret environment variables are showing up for the pod user but the web server instance does not see our environment variables.

This crashes our application because our server cannot connect to the database.

So somewhere in the 8.1 recipe, the web server user is no longer the same user that gets the openshift secrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.1 build - It's the latest/greatest/fastest and we're anxious to start using it.
3 participants