-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 8.1 versions for Fedora and RHEL9 #393
Conversation
[test-all] |
[test-all] |
[test-all] |
[test-all] |
4 similar comments
[test-all] |
[test-all] |
[test-all] |
[test-all] |
Let's try it once more time. The subscription account should be now fixed. [test-all] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues, which I have hit during the review.
Why do we have 8.1/.exclude-c9s
file and 8.1/Dockerfile.c9s
In case it is UBI based, then the Dockerfile
and exclude
file is not needed. This is a duplicity of Dockerfile.rhel9
which can be downloaded as UBI image.
[test-all] |
We're needing this still, what is remaining to do before this can pass tests and get merged? |
We're using OpenShift |
[test-openshift] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some nitpicks.
LGTM. Thanks. Let's wait for the tests.
Co-authored-by: Petr Hracek <[email protected]>
[test-all] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for adding new PHP version.
Let's wait whether container tests are passing. If so, then let's get merge it.
Ok so I've tested this 8.1, and have found the following: Our secret environment variables are showing up for the pod user but the web server instance does not see our environment variables. This crashes our application because our server cannot connect to the database. So somewhere in the 8.1 recipe, the web server user is no longer the same user that gets the openshift secrets. |
Resolves: #374