Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for installing a plugin #234

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Add a test for installing a plugin #234

merged 1 commit into from
Apr 11, 2024

Conversation

hhorak
Copy link
Member

@hhorak hhorak commented Apr 5, 2024 •
edited
Loading

This will fail until the plugin dir is fixed in the base.cnf file (fix suggested in #235).

@hhorak
Copy link
Member Author

hhorak commented Apr 5, 2024

[test]

@hhorak hhorak mentioned this pull request Apr 5, 2024
Merged
@phracek
Copy link
Member

phracek commented Apr 10, 2024

Test failed:

-----------------------------------------------
Running test run_plugin_test (starting at 2024-04-05 14:32:09+00:00) ... 
-----------------------------------------------
  Testing plugin installation
    Created container 66f8fd9a9e55803a746273b23524e4da95ce81229c1a1199f67ba5f9fa9b839d
  Testing MySQL connection to 10.88.0.174...
    Trying to connect....... OK
  Success!
ERROR 1126 (HY000) at line 1: Can't open shared library '/usr/lib64/mysql/plugin/sql_errlog.so' (errno: 2, cannot open shared object file: No such file or directory)
Test for image 'quay.io/sclorg/mariadb-103-c8s:1' FAILED (exit code: 1)
ERROR 1146 (42S02) at line 1: Table 'mysql.IdonotExist' doesn't exist
grep: /var/lib/mysql/data/sql_errors.log: No such file or directory
Test for image 'quay.io/sclorg/mariadb-103-c8s:1' FAILED (exit code: 2)
Test for image 'quay.io/sclorg/mariadb-103-c8s:1' FAILED (exit code: 2)
Tests finished with EXIT=0

==============================================

But it looks like it needs #235

@hhorak
Copy link
Member Author

hhorak commented Apr 10, 2024

[test]

phracek
phracek requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests passed, but I have missed the documentation about plugin.

test/run
test_connection "${test_name}" root rootpass
ip=$(ct_get_cip "${test_name}")

mysql_cmd "$ip" "root" "rootpass" -e "INSTALL PLUGIN SQL_ERROR_LOG SONAME 'sql_errlog' \G"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL_ERROR_LOG is the plugin or SONAME? I do not follow.
It is not clear to me as a database dummy folk. Is it documented somewhere?

If not, can you please add this to documentation?

@hhorak
Copy link
Member Author

hhorak commented Apr 10, 2024 •
edited
Loading

This test only follows what is documented in upstream: https://mariadb.com/kb/en/sql-error-log-plugin/
I don't personally see a need to duplicate upstream documentation here, although I'm not against if somebody volunteers to do it.

@phracek phracek merged commit ebabae1 into sclorg:master Apr 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhorak @phracek