Fix plugin directory in the config file #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A regression test for this plugin issue is added in #234. |
|
[test] |
Attempt to install the plugin currently fails with: $ echo "INSTALL PLUGIN sql_errlog SONAME 'sql_errlog';" | mysql -uroot ERROR 1126 (HY000) at line 1: Can't open shared library '/usr/lib64/mysql/plugin/sql_errlog.so' (errno: 11, cannot open shared object file: No such file or directory) It's not clear to me whether this file with path spec is still needed at all, especially in versions that do not have a build for SCL (if it was added for that reason at all). Maybe this base.cnf might be removed, but I didn't do proper analysis to be able to say that it's possible. So, applying minimal patch meanwhile.
|
[test] |
|
@FaramosCZ, as you've discovered this issue, please, review and ack if the fix looks sane to you. |
phracek
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to install the plugin currently fails with:
It's not clear to me whether this file with path spec is still needed at all, especially in versions that do not have a build for SCL (if it was added for that reason at all). Maybe this
base.cnfmight be removed, but I didn't do proper analysis to be able to say that it's possible. So, applying minimal patch meanwhile.@FaramosCZ found this issue, thanks for that.