Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on errordef override #937

Merged
merged 10 commits into from
Aug 30, 2023
Merged

Warn on errordef override #937

merged 10 commits into from
Aug 30, 2023

Conversation

HDembinski
Copy link
Member

Closes #930

  • Documentation is added to the iminuit.cost module which explains that errordef should not be set manually when the builtin cost functions are used.
  • Minuit now warns the user if Minuit.errordef is set if also the cost function has an errordef attribute, but the value set via Minuit.errordef still overrides the Cost.errordef attribute.

@HDembinski HDembinski merged commit 0963ae0 into develop Aug 30, 2023
7 checks passed
@HDembinski HDembinski deleted the warn_on_errordef_override branch August 30, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better documentation for errordef
1 participant
@HDembinski