Fix ROOT version in docs #1043
Merged
Fix ROOT version in docs #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We opt for a manual update strategy for the ROOT version, because it changes slowly and an efficient way to do it automatically in CI is elusive. Instructions were added to the release.md instructions and conf.py in the doc folder.
What is the problem with doing it in CI?
Since the ROOT repo is huge, we want to make shallow clones for git submodules, but then we cannot determine the relation of the commit to the closest tag, because that history which connects tag and commit is not there. Checking out all tags with
git pull --tagstakes a lot of bandwidth, and is not enough. We also need to check out the history between the latest tag and the commit. We don't know which tag the commit is closest to, so the best way would be to iteratively load the most recent history until the commit is connected to a tag.