Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for compressed handles #274

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add support for compressed handles #274

wants to merge 6 commits into from

Conversation

gab1one
Copy link
Contributor

@gab1one gab1one commented Jul 7, 2017 •
edited
Loading

This PR adds support for compressed handles, that operate on archives: namely .zip, .gzip and bzip2 archives.

This requires #339 and #340 to be merged first.

@gab1one gab1one force-pushed the more-handles-compressed branch 2 times, most recently from 71141df to 45fe1fb Compare July 11, 2017 10:57
@ctrueden
Copy link
Member

  • We should consider using Apache Commons Compress to read (and maybe write, though less important) these formats and more.
  • The locations should implement BrowsableLocation (as currently on master) such that code that works on arbitrary BrowsableLocation can work with no changes with these compressed formats.
  • ZipEntry is a lot like File, including stuff like last modified datestamp, which corresponds to DataHandle in our paradigm. So a ZipEntryHandle would make sense.
  • The ZipLocation points at a Location corresponding to the ZIP data. Its parent() method returns null. (It could return the containing folder of the zip, but this has pros and cons. We should perhaps experiment with that.)
  • A ZipElementLocation (naively, ZipEntryLocation, but it does not use java.util.zip.ZipEntry!) would have a parent ZipLocation together with a String for the entry name. It is not stateful.

@gab1one gab1one mentioned this pull request Oct 15, 2018
Merged
@gab1one gab1one changed the title Port support for Compressed Handles from scifio WIP: Port support for Compressed Handles from scifio Oct 15, 2018
@gab1one gab1one mentioned this pull request Oct 15, 2018
Merged
@gab1one gab1one force-pushed the more-handles-compressed branch 2 times, most recently from cbfe09d to ad90f9e Compare October 16, 2018 11:48
@ctrueden
Copy link
Member

@gab1one What is the status of this PR now?

@ctrueden ctrueden changed the title WIP: Port support for Compressed Handles from scifio Add support for compressed handles Nov 12, 2021
@ctrueden
Copy link
Member

I rebased this over the latest master, removing one commit that was obsolete (which fixed the handling of unknown lengths in an incompatible way with a different fix that was already merged). @hinerm I'd value your input on this PR at some point when you have time. No rush though.

@ctrueden ctrueden requested a review from hinerm November 12, 2021 22:13
@ctrueden ctrueden mentioned this pull request May 31, 2022
Open
@ctrueden ctrueden force-pushed the master branch 3 times, most recently from 53b6733 to 3dc99c9 Compare November 7, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinerm hinerm Awaiting requested review from hinerm

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gab1one @ctrueden