Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix molecule lint errors (TODO remove the unfinished multi-kdc commit) #1

Closed
wants to merge 11 commits into from
Closed

fix molecule lint errors (TODO remove the unfinished multi-kdc commit) #1

wants to merge 11 commits into from

Conversation

NadOby
Copy link

@NadOby NadOby commented Jun 18, 2019

Fixes # .

Changes proposed in this pull request:

Fixing issues with ansible-galaxy and should fix travis CI issues too.

lhoss and others added 11 commits May 15, 2019 17:55
@lhoss
WIP: support for multiple KDCs (untested)
a37101b
@NadOby
Fix ansible-lint errors
dccfbe2 
Trailing whitespaces
Adding 'set -o pipefail' to shell commands
@NadOby
Fix ansible-lint errors
299dff0 
Trailing whitespaces
@NadOby
Fix yamlint warning
488c846
@NadOby
Replace categories by galaxy tags
7024222 
Fixing: E702: Use 'galaxy_tags' rather than 'categories'
FIxing: E701: Role info should contain description
@NadOby
Fix copy/past error
7093235
@NadOby
Fix for molecule inconsistency
36d0547 
ansible/molecule#1727
@NadOby
Fix molecule version
6e2968c
@NadOby
Add flake8 installation
d42acda
@NadOby
Travis CI moved to python 3.6
16d2b78 
Pythton 2.7 will be deprecated at 01.01.2010
@NadOby
FIx ansible deprecation warning
3c8063f
@NadOby NadOby mentioned this pull request Jun 20, 2019
Open
@lhoss lhoss changed the base branch from support_multiple_kdcs to master June 24, 2019 17:02
@lhoss lhoss changed the title Support multiple kdcs fix molecule lint errors (TODO remove the unfinished multi-kdc commit) Jun 24, 2019
@lhoss lhoss mentioned this pull request Jun 25, 2019
Merged
@lhoss
Copy link
Collaborator

lhoss commented Jun 25, 2019

@NadOby thanks for your contribution in this PR
I rebased your commits to (upstream) master, to get rid of my initial WIP(PR) commit, and opened a new PR to upstream: ultratendency#23

I will rebase

@lhoss lhoss closed this Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NadOby @lhoss