i1046-admin-can-deposit-works-into-collections-to-main #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_service method on main
|
Tested on demo Before fix on demo screenshots
After fix on demo screenshots
|
ShanaLMoore
approved these changes
Jul 23, 2024
|
Just noting that I don't think the knapsack will need this fix since they are on hyrax 5 |
aprilrieger
deleted the
i1046-admin-can-deposit-works-into-collections-to-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the works controller decorator to remove params in collections_service method
Story
https://assaydepot.slack.com/archives/C0313NKC08L/p1721066260232569
A user is reporting an issue depositing works into collections they should have access to (as an admin).
This is on wabash.hykucommons.org
Refs #1046
Expected Behavior Before Changes
An admin could not add a work that they searched to a collection from the collection "Adds existing works to collection"
An admin could not add a work they searched for in the my/works page through the "Add to Collection button"
Expected Behavior After Changes
An admin can add a work that they searched to a collection from the collection "Adds existing works to collection"
An admin can add a work they searched for in the my/works page through the "Add to Collection button"
Screenshots / Video
Video of local demo of fix: https://share.zight.com/eDuKOD28
Click for BEFORE FIX Screenshots
Before: