Fixes #44 #45
Closed
Fixes #44 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is seen as too risky right now to be worth it. See discussion in the associated issue, #44 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issues in the coordinate generation for norbornane presented in #44:
1- templates were not applied to norbornane because coordgen counted only one central ring, while it should have found 2. The problem here was side rings were allowed to have up to 3 atoms in common with central rings. This has been corrected, and now only 2 common atoms are allowed. I'm not quite sure about the impact this might have.
2- A template for norbornane has been added.
I checked that the coordinates are now ok by using the same check as @greglandrum used in #44:
