Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code ank2829 issue51 #123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CodeAnk2829
Copy link

Resolve the issue #51 as mentioned

@ricrogz
Copy link
Collaborator

ricrogz commented Mar 30, 2023

HI @CodeAnk2829, thanks for your PR. You indeed made the changes suggested in the issue, but as I also mentioned in the issue, since we don't have proper testing in place to make sure these changes don't break the functionality, I'd rather not merge these changes without proper testing.

@CodeAnk2829
Copy link
Author

Thanks @ricrogz for replying. I realized that I have missed something and I will look into the issue again. As of now can you please assign me this issue? because I think I can fix this issue with proper testing.

@ricrogz
Copy link
Collaborator

ricrogz commented Mar 31, 2023

Thanks @ricrogz for replying. I realized that I have missed something and I will look into the issue again. As of now can you please assign me this issue? because I think I can fix this issue with proper testing.

@CodeAnk2829, please don't worry about this. The issue was just filed to document a minor problem that doesn't affect the functionality of the library. Like I said, we won't merge any fixes to this issue because don't have any testing infrastructure in place to make sure that a potential fix doesn't break the functionality in an unexpected way. By now, it is not in our priorities to create such testing infrastructure or fix this issue.

@CodeAnk2829
Copy link
Author

Ok @ricrogz, now I understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants