chore(composer): Update doctrine code standards to 12.x #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scyzoryck
changed the title
|
Merging to unblock @mbabker work :) |
|
I will take a look at the failing master pipeline later today & provide the fixes. :( |
|
The one fail is related to the ORM 2.16 release, doctrine/orm#10864 if you're interested in why it's seemingly a bigger issue for other projects (here it just messes up the JSON string comparison). The errors are because in rebasing #1494 I managed to change a FQCN reference for the annotation to a short name without a use statement, oops. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's go one more step in compare to: #1305
Newest version is 12, but with 10 it started to require one line comments :) Do we also want to go that way?