[scalar-manager] Create the Helm chart for Scalar Manager #254
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,16 +2,20 @@ apiVersion: v2 | |
| name: scalar-manager | ||
| description: Scalar Manager | ||
| type: application | ||
| version: 3.0.0-SNAPSHOT | ||
| appVersion: 3.0.0-SNAPSHOT | ||
| deprecated: false | ||
| icon: https://scalar-labs.com/wp-content/themes/scalar/assets/img/logo_scalar.svg | ||
| keywords: | ||
| - scalar-manager | ||
| - scalardb-cluster | ||
| - scalardl-ledger | ||
| - scalardl-auditor | ||
| - scalar-admin-for-kubernetes | ||
| home: https://scalar-labs.com/ | ||
| sources: | ||
| - https://github.com/scalar-labs/scalar-manager-api | ||
| - https://github.com/scalar-labs/scalar-manager-web | ||
| maintainers: | ||
| - name: Takanori Yokoyama | ||
| email: [email protected] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,38 @@ | ||
| # scalar-manager | ||
|
|
||
|    | ||
|
|
||
| Scalar Manager | ||
| Current chart version is `3.0.0-SNAPSHOT` | ||
|
|
||
| **Homepage:** <https://scalar-labs.com/> | ||
|
|
||
| ## Values | ||
|
|
||
| | Key | Type | Default | Description | | ||
| |-----|------|---------|-------------| | ||
| | api.applicationProperties | string | The minimum template of application.properties is set by default. | The application.properties for Scalar Manager. If you want to customize application.properties, you can override this value with your application.properties. | | ||
| | api.image.pullPolicy | string | `"IfNotPresent"` | | | ||
| | api.image.repository | string | `"ghcr.io/scalar-labs/scalar-manager-api"` | | | ||
| | api.image.tag | string | `""` | | | ||
| | api.resources | object | `{}` | | | ||
| | fullnameOverride | string | `""` | | | ||
| | imagePullSecrets[0].name | string | `"reg-docker-secrets"` | | | ||
| | nameOverride | string | `""` | | | ||
| | nodeSelector | object | `{}` | | | ||
| | podAnnotations | object | `{}` | | | ||
| | podLabels | object | `{}` | | | ||
| | podSecurityContext.seccompProfile.type | string | `"RuntimeDefault"` | | | ||
| | replicaCount | int | `1` | | | ||
| | securityContext.allowPrivilegeEscalation | bool | `false` | | | ||
| | securityContext.capabilities.drop[0] | string | `"ALL"` | | | ||
| | securityContext.runAsNonRoot | bool | `true` | | | ||
| | service.port | int | `80` | | | ||
| | service.type | string | `"ClusterIP"` | | | ||
| | serviceAccount.automountServiceAccountToken | bool | `true` | | | ||
| | serviceAccount.serviceAccountName | string | `""` | | | ||
| | tolerations | list | `[]` | | | ||
| | web.image.pullPolicy | string | `"IfNotPresent"` | | | ||
| | web.image.repository | string | `"ghcr.io/scalar-labs/scalar-manager-web"` | | | ||
| | web.image.tag | string | `""` | | | ||
| | web.resources | object | `{}` | | |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: {{ include "scalar-manager.fullname" . }} | ||
| labels: | ||
| {{- include "scalar-manager.labels" . | nindent 4 }} | ||
| rules: | ||
| - apiGroups: [""] | ||
| resources: ["pods", "services", "namespaces", "configmaps", "secrets", "serviceaccounts"] | ||
| verbs: ["get", "list", "create", "patch", "delete", "update"] | ||
| - apiGroups: ["batch"] | ||
| resources: ["cronjobs", "jobs"] | ||
| verbs: ["get", "list", "create", "delete"] | ||
| - apiGroups: ["apps"] | ||
| resources: ["deployments"] | ||
| verbs: ["get", "list"] | ||
| - apiGroups: ["rbac.authorization.k8s.io"] | ||
| resources: ["roles", "rolebindings"] | ||
| verbs: ["get", "list", "create", "delete"] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| name: {{ include "scalar-manager.fullname" . }} | ||
| labels: | ||
| {{- include "scalar-manager.labels" . | nindent 4 }} | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: {{ include "scalar-manager.serviceAccountName" . }} | ||
| namespace: {{ .Release.Namespace }} | ||
| apiGroup: "" | ||
| roleRef: | ||
| kind: ClusterRole | ||
| name: {{ include "scalar-manager.fullname" . }} | ||
| apiGroup: rbac.authorization.k8s.io |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| apiVersion: v1 | ||
|
There was a problem hiding this comment. Just a question. I think this ConfigMap is used for storing cluster and pause information. And, it seems that this chart adds Do we need to create this I want to confirm whether Scalar Manager API can create (If Scalar Manager can create There was a problem hiding this comment. As we discussed, we will update Scalar Manager API to create There was a problem hiding this comment. As we discussed, we noticed that this There was a problem hiding this comment. We address this issue on the Scalar Manager API side. |
||
| kind: ConfigMap | ||
| metadata: | ||
| name: {{ include "scalar-manager.fullname" . }}-api-application-properties | ||
| namespace: {{ .Release.Namespace }} | ||
| labels: | ||
| {{- include "scalar-manager.labels" . | nindent 4 }} | ||
| data: | ||
| scalar-manager-api-application.properties: | ||
| {{- toYaml .Values.api.applicationProperties | nindent 4 }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,73 @@ | ||||
| apiVersion: apps/v1 | ||||
| kind: Deployment | ||||
| metadata: | ||||
| name: {{ include "scalar-manager.fullname" . }} | ||||
| namespace: {{ .Release.Namespace }} | ||||
| labels: | ||||
| {{- include "scalar-manager.labels" . | nindent 4 }} | ||||
| spec: | ||||
| replicas: {{ .Values.replicaCount }} | ||||
| selector: | ||||
| matchLabels: | ||||
| {{- include "scalar-manager.selectorLabels" . | nindent 6 }} | ||||
| template: | ||||
| metadata: | ||||
| annotations: | ||||
| checksum/config: {{ include (print $.Template.BasePath "/scalar-manager/configmap.yaml") . | sha256sum }} | ||||
|
There was a problem hiding this comment.
Suggested change
I think this If the above understanding is correct, this So, I think we can remove this annotation. There was a problem hiding this comment. As we discussed, we will remove this annotation. There was a problem hiding this comment. As we discussed in another comment, we decided to use |
||||
| {{- if .Values.podAnnotations }} | ||||
| {{- toYaml .Values.podAnnotations | nindent 8 }} | ||||
| {{- end }} | ||||
| labels: | ||||
| {{- include "scalar-manager.selectorLabels" . | nindent 8 }} | ||||
| {{- if .Values.podLabels }} | ||||
| {{- toYaml .Values.podLabels | nindent 8 }} | ||||
| {{- end }} | ||||
| spec: | ||||
| restartPolicy: Always | ||||
| serviceAccountName: {{ include "scalar-manager.serviceAccountName" . }} | ||||
| automountServiceAccountToken: {{ .Values.serviceAccount.automountServiceAccountToken }} | ||||
| containers: | ||||
| - name: {{ .Chart.Name }}-api | ||||
| image: "{{ .Values.api.image.repository }}:{{ .Values.api.image.tag | default .Chart.AppVersion }}" | ||||
| resources: | ||||
| {{- toYaml .Values.api.resources | nindent 12 }} | ||||
| ports: | ||||
| - containerPort: 8080 | ||||
| imagePullPolicy: {{ .Values.api.image.pullPolicy }} | ||||
| securityContext: | ||||
| {{- toYaml .Values.securityContext | nindent 12 }} | ||||
| volumeMounts: | ||||
| - name: api-application-properties-volume | ||||
| mountPath: /app/application.properties | ||||
| subPath: scalar-manager-api-application.properties | ||||
| - name: {{ .Chart.Name }}-web | ||||
|
There was a problem hiding this comment. If my remembering is correct, Scalar Manager works as follows. +-[Kubernetes Cluster A]---+ +-[Kubernetes Cluster B]---+ +-[Kubernetes Cluster C]---+
| | | | | |
| +--------------------+ | | +--------------------+ | | +--------------------+ |
| | Scalar products | | | | Scalar products | | | | Scalar products | |
| +--------------------+ | | +--------------------+ | | +--------------------+ |
| | | | | |
| +--------------------+ | | +--------------------+ | | +--------------------+ |
| | Scalar Manager API | | | | Scalar Manager API | | | | Scalar Manager API | |
| +--------------------+ | | +--------------------+ | | +--------------------+ |
| | | | | | | | |
+------------+-------------+ +------------+-------------+ +------------+-------------+
| | |
| | |
| | |
+-----------------------------+-----------------------------+
|
|
|
+---------+----------+
| Scalar Manager Web |
+--------------------+So, we don't need to deploy Vice versa, it would be better to deploy Is my understanding correct? (Sorry, I might miss some Scalar Manager specifications...) There was a problem hiding this comment. As we discussed, at this time, we must deploy |
||||
| image: "{{ .Values.web.image.repository }}:{{ .Values.web.image.tag | default .Chart.AppVersion }}" | ||||
| resources: | ||||
| {{- toYaml .Values.web.resources | nindent 12 }} | ||||
| ports: | ||||
| - containerPort: 3000 | ||||
| imagePullPolicy: {{ .Values.web.image.pullPolicy }} | ||||
| securityContext: | ||||
| {{- toYaml .Values.securityContext | nindent 12 }} | ||||
| volumes: | ||||
| - name: api-application-properties-volume | ||||
| configMap: | ||||
| name: {{ include "scalar-manager.fullname" . }}-api-application-properties | ||||
| securityContext: | ||||
| {{- toYaml .Values.podSecurityContext | nindent 8 }} | ||||
| {{- with .Values.imagePullSecrets }} | ||||
| imagePullSecrets: | ||||
| {{- toYaml . | nindent 8 }} | ||||
| {{- end }} | ||||
| {{- with .Values.nodeSelector }} | ||||
| nodeSelector: | ||||
| {{- toYaml . | nindent 8 }} | ||||
| {{- end }} | ||||
| {{- with .Values.affinity }} | ||||
| affinity: | ||||
| {{- toYaml . | nindent 8 }} | ||||
| {{- end }} | ||||
| {{- with .Values.tolerations }} | ||||
| tolerations: | ||||
| {{- toYaml . | nindent 8 }} | ||||
| {{- end }} | ||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,16 @@ | ||
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: {{ include "scalar-manager.fullname" . }} | ||
| namespace: {{ .Release.Namespace }} | ||
| labels: | ||
| {{- include "scalar-manager.labels" . | nindent 4 }} | ||
| spec: | ||
| type: {{ .Values.service.type }} | ||
| ports: | ||
| - protocol: TCP | ||
| name: web | ||
| port: {{ .Values.service.port }} | ||
| targetPort: 3000 | ||
| selector: | ||
| {{- include "scalar-manager.selectorLabels" . | nindent 4 }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question. What is the reason why we use
ClusterRoleinstead ofRole?In other words, does Scalar Manager access the following resources that need the
ClusterRole?https://kubernetes.io/docs/reference/access-authn-authz/rbac/#clusterrole-example
/healthz)