Revise the Getting Started Monitoring guide to support Scalar Manager
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supl
commented
Jan 29, 2024
|
|
There was a problem hiding this comment.
Sorry, my editor automatically removes the spaces.
josh-wong
requested changes
Jan 29, 2024
|
@josh-wong @kota2and3kan Could you take a look at the suggestions as well?
Thank you 🙇 |
kota2and3kan
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Thank you for the update!
Overall looks good to me, but I have one very minor question.
@josh-wong
Could you please take a look at my question when you have time?
Co-authored-by: Josh Wong <[email protected]>
Co-authored-by: Josh Wong <[email protected]>
Co-authored-by: Josh Wong <[email protected]>
|
@josh-wong @kota2and3kan |
This was referenced Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR revised the "Getting Started with Helm Charts (Monitoring using Prometheus Operator)" document to add the description about supporting Scalar Manager to collect CPU and memory resources.
Scalar Manager relies on Prometheus Stack to do so and some configurations need to be set correctly.
Related issues and/or PRs
N/A
Changes made
Checklist
Release notes
Added description to "Getting Started with Helm Charts (Monitoring using Prometheus Operator)" to support Scalar Manager to collect the CPU and memory resources