Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshot version to keep main branch latest #247

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

kota2and3kan
Copy link
Collaborator

Description

This PR updates the product versions in the main branch.

We released the first version (v1.0.0) helm chart of ScalarDB Analytics with PostgreSQL and Scalar Admin for Kubernetes

To keep the versions of these products latest in the main branch, I updated those versions.

Related issues and/or PRs

N/A

Changes made

  • Update chart and product versions.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

Comment on lines +5 to +6
version: 2.0.0-SNAPSHOT
appVersion: 2.0.0-SNAPSHOT
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scalar Admin for Kubernetes has the SNAPSHOT version. So, I use the SNAPSHOT version for appVersion in the main branch.
https://github.com/scalar-labs/scalar-admin-for-kubernetes/pkgs/container/scalar-admin-for-kubernetes/166941489?tag=2.0.0-SNAPSHOT

Comment on lines +5 to 6
version: 2.0.0-SNAPSHOT
appVersion: 3.10.3
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScalarDB Analytics with PostgreSQL does not have the SNAPSHOT version at this time.
https://github.com/orgs/scalar-labs/packages/container/scalardb-analytics-postgresql/versions?filters%5Bversion_type%5D=tagged

Before, we discussed it and we will provide the SNAPSHOT version in the future.
However, for now, I use the latest stable version for appVersion in the chart of ScalarDB Analytics with PostgreSQL.

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 1a28aa0 into main Jan 17, 2024
14 checks passed
@feeblefakie feeblefakie deleted the update-main-branch-to-use-snapshot-version branch January 17, 2024 08:09
@feeblefakie
Copy link
Contributor

@choplin @supl @kota2and3kan Sorry, I accidentally merged it. PTAL and leave comments if any. 🙇

@supl
Copy link
Contributor

supl commented Jan 17, 2024

No problem.
LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants