Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Translate widget to navbar #143

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

josh-wong
Copy link
Member

Description

This PR adds a Google Translate widget to the navigation bar (navbar) so that users can translate pages into Japanese.

Related issues and/or PRs

N/A

Changes made

  • Swizzled the navbar (NavbarItem) component, and added code for the Google Translate widget.
  • Added a helper, which is used for rendering the widget in the navbar.
  • Added the widget as an item in the navbar.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have updated the side navigation as necessary.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@josh-wong josh-wong added the enhancement New feature or request label Aug 8, 2024
@josh-wong josh-wong self-assigned this Aug 8, 2024
@josh-wong josh-wong merged commit b7b8237 into main Aug 8, 2024
1 check passed
@josh-wong josh-wong deleted the add-google-translate-widget branch August 8, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant