Clean up boilerplate #432
Merged
Clean up boilerplate #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a lot of methods whose results are cached using what is essentially a thread-unsafe Context-dependent lazy val. We encode the common shape of the initialization logic in an internal method `Utils.memoized`.
`Symbols` have a number of fields that are set after their creation by the readers. They must be set exactly once, and must be set before they are read. We extract `assignOnce` and `getAssignedOnce` to encode the boilerplate of that pattern.
We keep `withX` names for methods that return new instances without changing the original.
sjrd
force-pushed
the
cleanup-boilerplate
branch
from
e509158
to
0ed0945
Compare
adpi2
approved these changes
Dec 21, 2023
| inline def getAssignedOnce[A](value: A | Null)(inline msgIfNotAssignedYet: => String): A = | ||
| if value != null then value | ||
| else | ||
| // Extracted in a separate def for good jitting of the code calling `getAssignedOnce` |
There was a problem hiding this comment.
Is it because the JIT compiler won't compile the local def until it is called (which should rarely happen)?
Does it really make a difference?
There was a problem hiding this comment.
It's mostly that the regular getter remains small, under the limit that will always be inlined. The bytecode-long initialization path is extracted in a separate def. This is the same strategy that we use when compiling lazy vals. The getter does the cheap and short test whether it is already initialized, and if not it delegates to the lzy$compute method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.