Further clean up the Scala 2 pickle reader. #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need the `typeParams` when completing the type of constructors, and the types of constructors are not needed by the class. Therefore, we can move reading `typeParams` until completing the type of the class. This simplifies things, because previously we were doing a sort of look-ahead inside the `POLYtpe`, which also required having a special non-caching version of `at()`. Now we can genuinely read the `POLYtpe` and extract the type parameters from it after the fact.
Now that types are read afterwards, including class type parameters, there are no more cyclic dependencies while creating symbols. Therefore, we can get rid of the all the machinery that supported eagerly filling in the `entries` from within `readMaybeExternalSymbol()`.
Previously, we tried to write "generic" code for handling all the special cases to apply to names and flags. However, that was making the logic harder than necessary, with too many possible branching paths. We now move that logic inside the various `case`s of `tag match`. This makes the logic simpler overall.
adpi2
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.