Make Constants.Constant final. #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
approved these changes
Nov 17, 2023
|
Hypothetically if there are custom trees allowed maybe there could be custom constants |
This is technically a compatibility breach, both at the binary and TASTy level. However, I don't see how anyone could have meaningfully extended `Constant` (also we have 2 users so far).
sjrd
force-pushed
the
finalize-constant
branch
from
d10221e
to
15dff42
Compare
adpi2
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially controversial.
This is technically a compatibility breach, both at the binary and TASTy level. However, I don't see how anyone could have meaningfully extended
Constant(also we have 2 users so far).