Read Java annotations. #389
Conversation
sjrd
force-pushed
the
java-annotations
branch
3 times, most recently
from
e0b4960
to
d35c1fb
Compare
|
|
||
| case AnnotationValue.ClassConst(descriptor) => | ||
| val classType = JavaSignatures.parseReturnDescriptor(descriptor.name) | ||
| Literal(Constant(classType))(pos) |
There was a problem hiding this comment.
documentation of Constant should mention that this can be a raw class type (aka unapplied generic class)
There was a problem hiding this comment.
maybe add a test for a generic external class
There was a problem hiding this comment.
Added documentation + test.
| @@ -38,10 +38,51 @@ private[classfiles] object JavaSignatures: | |||
| superRef :: interfaces.map(classRef).toList | |||
| end parseSupers | |||
|
|
|||
| def parseReturnDescriptor(descriptor: String)(using ReaderContext, InnerClasses, Resolver): Type = | |||
There was a problem hiding this comment.
this is also implemented by the local method result inside of parseSignature, so I wonder if it can be reused with refactoring?
There was a problem hiding this comment.
Yes, I know. It's not that easy, however, because the more capable parseSignature expects a member: TermOrTypeSymbol that the signature attaches to, which we have no business having here. Factoring this out would require significant refactoring of the whole parsing, so I would rather not do that here (at least not at this point).
sjrd
force-pushed
the
java-annotations
branch
from
d35c1fb
to
d7aede0
Compare
Bonus: read Java parameter names.