Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: erase scrollback when clearing the screen" #2349

Closed

Conversation

s-nel
Copy link

@s-nel s-nel commented Jun 5, 2024

Reverts #2267 which clears backscroll of the console when in --watch mode.

Fixes: #2348

@tgodzik tgodzik requested a review from kpodsiad June 5, 2024 13:03
@tgodzik
Copy link
Contributor

tgodzik commented Jun 5, 2024

@kpodsiad what do you think?

@kpodsiad
Copy link
Collaborator

kpodsiad commented Jun 5, 2024

Fixing one's workflow breaks another one - https://xkcd.com/1172/

Scroll was being cleared previously, but it was cleared improperly. So I think by design and by default watch mode should clear the scroll.

However, I understand @s-nel preference to not clear it. I wonder, maybe this can be an additional flag? What do you guys think about that?

@tgodzik
Copy link
Contributor

tgodzik commented Jun 5, 2024

However, I understand @s-nel preference to not clear it. I wonder, maybe this can be an additional flag? What do you guys think about that?

I think flag is the only option to have both cases satisfied

@s-nel
Copy link
Author

s-nel commented Jun 5, 2024

Scroll was being cleared previously, but it was cleared improperly

It wasn't clearing scroll for me previously. When I start a watch command the console adds a bunch of space so that new lines appear at the top of the console, but everything that ran before is still present in the scrollback. E.g. below I have one --watch running, I cancel it, then I start a new --watch. The new watch starts at the top of the console but it hasn't cleared anything in the scroll.

===============================================
Total duration: 14s
All 1 test suites passed.
===============================================
Watching 50 directories... (press Ctrl-C to interrupt)
^C
$ bloop test ... --watch






























^C
$

In any case, I would be happy with a flag

@s-nel s-nel closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollback cleared when in --watch mode
3 participants