Announcing Scala.js 1.17.0, and add doc for the Wasm backend. #646

sjrd · 2024-09-22T11:44:49Z

Preparing a bit in advance this time, to review the docs about the Wasm backend and communicate its experimental status.

gzm0

Only nits. Maybe it makes sense for @tanishiking to have a look at webassembly.md?

gzm0 · 2024-09-24T17:57:46Z

_data/doc.yml

@@ -28,7 +28,9 @@
    - text: Emitting modules
      url: /doc/project/module.html
    - text: JavaScript Environments
-      url: /doc/project/js-environments.html
+      url: /doc/project/js-environments.htmlhtml


Suggested change

url: /doc/project/js-environments.htmlhtml

url: /doc/project/js-environments.html

gzm0 · 2024-09-24T18:12:12Z

_posts/news/2024-09-25-announcing-scalajs-1.17.0.md

+This is a **minor** release:
+
+* It is backward binary compatible with all earlier versions in the 1.x series: libraries compiled with 1.0.x through 1.16.x can be used with 1.17.0 without change.
+* It is *not* forward binary compatible with 1.15.x: libraries compiled with 1.17.0 cannot be used with 1.16.x or earlier.


Suggested change

* It is *not* forward binary compatible with 1.15.x: libraries compiled with 1.17.0 cannot be used with 1.16.x or earlier.

* It is *not* forward binary compatible with 1.16.x: libraries compiled with 1.17.0 cannot be used with 1.16.x or earlier.

gzm0 · 2024-09-24T18:13:12Z

_posts/news/2024-09-25-announcing-scalajs-1.17.0.md

+* The reference types in the IR, such as `ClassType` and `ArrayType`, now have a `nullable: Boolean` flag.
+  There is also a new type `AnyNotNullType`.
+* The `NewArray` node does not accept multiple dimensions anymore.
+  If you want to emit a multi-dimensional array creation, emit a call to `java.lang.reflect.Array.newInstance` instead.


Just to double check: The only other change was the jl.Class change?

That and CheckNotNull, which is also an addition to UnaryOp. These are unlikely to hit other people who manipulate IR nodes, since they are confined to the javalib in practice.

gzm0 · 2024-09-24T18:13:45Z

_posts/news/2024-09-25-announcing-scalajs-1.17.0.md

+    .withArgs(List(
+      "--experimental-wasm-exnref", // required
+      "--experimental-wasm-imported-strings", // optional (good for performance)
+      "--turboshaft-wasm", // optional, bug significantly increases stability


Suggested change

"--turboshaft-wasm", // optional, bug significantly increases stability

"--turboshaft-wasm", // optional, but significantly increases stability

Otherwise it's funny :P

gzm0 · 2024-09-24T18:15:10Z

_posts/news/2024-09-25-announcing-scalajs-1.17.0.md

+Moreover, the codebase must not contain any feature that require emitting multiple modules: `@JSExportToplevel` annotations with several module names, or `js.dynamicImport`.
+We expect to lift that limitation in the future.
+
+Other than that, we expect the WebAssembly backend to support all of Scala.js semantics.


Suggested change

Other than that, we expect the WebAssembly backend to support all of Scala.js semantics.

Other than that, we expect the WebAssembly backend to support all of Scala.js' semantics.

or

Suggested change

Other than that, we expect the WebAssembly backend to support all of Scala.js semantics.

Other than that, we expect the WebAssembly backend to support all Scala.js semantics.

tanishiking

Only one comment on requirements, otherwise looks good to me :)

tanishiking · 2024-09-25T02:57:33Z

_posts/news/2024-09-25-announcing-scalajs-1.17.0.md

+If you want to use it in browsers, you will need:
+
+* For Firefox: in `about:config`, enable `javascript.options.wasm_exnref`.
+  Also make sure to *disable* `javascript.options.wasm_js_string_builtins`: Firefox has two issues with it that break Scala.js ([1919901](https://bugzilla.mozilla.org/show_bug.cgi?id=1919901) and [1920337](https://bugzilla.mozilla.org/show_bug.cgi?id=1920337))


Nice catch! 😮

tanishiking · 2024-09-25T03:02:33Z

doc/project/webassembly.md

+
+* A JavaScript host (i.e., we do not currently generate standalone Wasm)
+* A Wasm engine with support for:
+  * Wasm 3.0


Suggested change

* Wasm 3.0

* Wasm 2.0

?

Wasm 2.0 does not contain return_call yet, which we also use. Wasm 3.0 does contain GC, so we could omit it in theory, but in practice IMO it matters a lot more that we need GC, since that has less widespread support.

Ah, that makes sense. Didn't know return_call is not in 2.0

gzm0 · 2024-09-25T05:39:25Z

doc/project/webassembly.md

+* Future versions of Scala.js may emit Wasm that requires *newer* versions of Wasm engines, dropping support for older engines.
+
+However, we do *not* expect the *quality* of the Wasm backend to be any lower than the JS backend.
+Feel free to report any issue you may experience with the same expectations as for the JS backend.


Just thought about this: You might want to drop a line here about semantics v.s. performance:
IIUC as far as semantics are concerned, we expect full parity, as far as performance is concerned, we still expect improvements. (IMHO the text in the release announcement captures this quite nicely, probably can just be copied).

Also codesize and linker incrementality, actually?

sjrd

Updated.

sjrd · 2024-09-25T13:19:46Z

_posts/news/2024-09-25-announcing-scalajs-1.17.0.md

+* The reference types in the IR, such as `ClassType` and `ArrayType`, now have a `nullable: Boolean` flag.
+  There is also a new type `AnyNotNullType`.
+* The `NewArray` node does not accept multiple dimensions anymore.
+  If you want to emit a multi-dimensional array creation, emit a call to `java.lang.reflect.Array.newInstance` instead.


That and CheckNotNull, which is also an addition to UnaryOp. These are unlikely to hit other people who manipulate IR nodes, since they are confined to the javalib in practice.

sjrd · 2024-09-25T13:30:09Z

doc/project/webassembly.md

+
+* A JavaScript host (i.e., we do not currently generate standalone Wasm)
+* A Wasm engine with support for:
+  * Wasm 3.0


Wasm 2.0 does not contain return_call yet, which we also use. Wasm 3.0 does contain GC, so we could omit it in theory, but in practice IMO it matters a lot more that we need GC, since that has less widespread support.

sjrd requested a review from gzm0 September 22, 2024 11:44

sjrd force-pushed the scalajs-1.17.0 branch 2 times, most recently from 95df5a2 to 2642144 Compare September 24, 2024 07:53

gzm0 approved these changes Sep 24, 2024

View reviewed changes

tanishiking approved these changes Sep 25, 2024

View reviewed changes

gzm0 reviewed Sep 25, 2024

View reviewed changes

sjrd force-pushed the scalajs-1.17.0 branch from 2642144 to 7b36cc2 Compare September 25, 2024 13:51

sjrd commented Sep 25, 2024

View reviewed changes

gzm0 approved these changes Sep 28, 2024

View reviewed changes

Announcing Scala.js 1.17.0, and add doc for the Wasm backend.

08d2baf

sjrd force-pushed the scalajs-1.17.0 branch from 7b36cc2 to 08d2baf Compare September 28, 2024 08:11

sjrd marked this pull request as ready for review September 28, 2024 08:12

sjrd merged commit 41707f6 into scala-js:main Sep 28, 2024
1 check passed

sjrd deleted the scalajs-1.17.0 branch September 28, 2024 08:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Announcing Scala.js 1.17.0, and add doc for the Wasm backend. #646

Announcing Scala.js 1.17.0, and add doc for the Wasm backend. #646

sjrd commented Sep 22, 2024

gzm0 left a comment

gzm0 Sep 24, 2024

gzm0 Sep 24, 2024

gzm0 Sep 24, 2024

sjrd Sep 25, 2024

gzm0 Sep 24, 2024

gzm0 Sep 24, 2024

tanishiking left a comment

tanishiking Sep 25, 2024

tanishiking Sep 25, 2024

sjrd Sep 25, 2024

tanishiking Sep 27, 2024 •

edited

Loading

gzm0 Sep 25, 2024

gzm0 Sep 25, 2024

sjrd left a comment

sjrd Sep 25, 2024

sjrd Sep 25, 2024

	url: /doc/project/js-environments.htmlhtml
	url: /doc/project/js-environments.html

	* It is not forward binary compatible with 1.15.x: libraries compiled with 1.17.0 cannot be used with 1.16.x or earlier.
	* It is not forward binary compatible with 1.16.x: libraries compiled with 1.17.0 cannot be used with 1.16.x or earlier.

	"--turboshaft-wasm", // optional, bug significantly increases stability
	"--turboshaft-wasm", // optional, but significantly increases stability

	Other than that, we expect the WebAssembly backend to support all of Scala.js semantics.
	Other than that, we expect the WebAssembly backend to support all of Scala.js' semantics.

Announcing Scala.js 1.17.0, and add doc for the Wasm backend. #646

Announcing Scala.js 1.17.0, and add doc for the Wasm backend. #646

Conversation

sjrd commented Sep 22, 2024

gzm0 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tanishiking left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tanishiking Sep 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sjrd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tanishiking Sep 27, 2024 •

edited

Loading