Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Java patch version #881

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Bump Java patch version #881

wants to merge 1 commit into from

Conversation

razorheadfx
Copy link

Changed 11.0.4.hs-adpt to 11.0.6.hs-adpt in install command as 11.0.4 is no longer available on SDKMAN.

Currently this will require the docs to change every time AdoptOpenJDK retires/unlists a version.
I just used SDKMAN for the first time so i assumed the guide was up to date (silly me :D) maybe explicitly forcing the user to list and select a version explicitely could prevent this fallacy for other first timers of both sbt and sdk.

For example

# use SDKMAN to list java versions
sdk java list
# select a AdoptOpenJDK 11 release version 11.y.z  and then install it like so
sdk install java 11.<y>.<z>.hs-adpt

Changed ```11.0.4.hs-adpt``` to ```11.0.6.hs-adpt``` in install command as 11.0.4 is no longer available on SDKMAN.


Currently this will require the docs to change every time  AdoptOpenJDK retires/unlists a version.
I just used SDKMAN for the first time so i assumed the guide was up to date (silly me :D) maybe explicitly forcing the user to list and select a version explicitely could easy for other first time users of both ```sbt``` and ```sdk```.
For example
```
# use SDKMAN to list java versions
sdk java list
# select a AdoptOpenJDK 11 release version 11.y.z  and then install it like so
sdk install java 11.<y>.<z>.hs-adpt
```
@lightbend-cla-validator

Hi @razorheadfx,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@eed3si9n
Copy link
Member

@razorheadfx Thanks for the contribution. I think your suggestion about making it x y etc makes sense so we don't need to keep updating it.

A more automated way of doing that is

sdk install java $(sdk list java | grep -o "$11\.[0-9\.]*hs-adpt" | head -1) || true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants