Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clang++ compile warnings #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bsergean
Copy link

Hi there, small PR to fix some warnings.

@bsergean
Copy link
Author

bsergean commented May 10, 2017

core/src/rtm.c:528:17: warning: ISO C++11 does not allow conversion from string literal to
      'char *' [-Wwritable-strings]
    auto_port = "80";
                ^
core/src/rtm.c:532:17: warning: ISO C++11 does not allow conversion from string literal to
      'char *' [-Wwritable-strings]
    auto_port = "443";
                ^
2 warnings generated.
rtm.h:35:9: warning: 'USE_TLS' macro redefined [-Wmacro-redefined]
#define USE_TLS
        ^
my_file.h:13:9: note: previous definition is here
#define USE_TLS 1

@satori-avasenin
Copy link
Contributor

We are working to remove USE_TLS define completely because our main endpoint works only on TLS so it doesn't make any sense to build SDK without TLS. I will cherry-pick you changes about string literal to cstring convention. Will push them until the end of week.

@bsergean
Copy link
Author

Sounds good / I reverted that change and pushed to my master, maybe it will make merging this easier.

@bsergean
Copy link
Author

I've added something unrelated to this commit ... I should have made a branch.

f640ceb adds 2 files that are required if one wants to build with autotools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants