Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable find in result pane #714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: enable find in result pane #714

wants to merge 1 commit into from

Conversation

scnwwu
Copy link
Member

@scnwwu scnwwu commented Dec 19, 2023

Summary
Resolve #700

Testing

  1. Run code to get HTML result
  2. Focus in the Result pane
  3. Press the find shortcut (by default Ctrl+F on Windows)

@scnwwu scnwwu added this to the 1.7.0 milestone Dec 21, 2023
@Zhirong2022 Zhirong2022 added testing Test the pull requests and removed verification-needed labels Dec 21, 2023
@Zhirong2022
Copy link
Collaborator

VSC will quit in certain case

  1. Run some SAS code
  2. Ctrl+f to open Find control
  3. Type something in find input box and perform search, then keep Find control on the page
  4. Click other tab page
  5. Click result tab page, VSC will quit unexpectedly

@scnwwu
Copy link
Member Author

scnwwu commented Dec 25, 2023

VSC will quit in certain case

  1. Run some SAS code
  2. Ctrl+f to open Find control
  3. Type something in find input box and perform search, then keep Find control on the page
  4. Click other tab page
  5. Click result tab page, VSC will quit unexpectedly

Reported to microsoft/vscode#201478

@scnwwu scnwwu removed the testing Test the pull requests label Jan 17, 2024
@scnwwu
Copy link
Member Author

scnwwu commented Jan 17, 2024 •
edited
Loading

Blocked by the VS Code issue. Will revisit after the blocking issue resolved.

@scnwwu scnwwu removed this from the 1.7.0 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottdover scottdover scottdover approved these changes

@smorrisj smorrisj Awaiting requested review from smorrisj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search in Result pane
3 participants
@scnwwu @Zhirong2022 @scottdover