Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Added SAS Arke dashboard to Grafana #589

Merged
merged 4 commits into from
Dec 12, 2023
Merged

[feature] Added SAS Arke dashboard to Grafana #589

merged 4 commits into from
Dec 12, 2023

Conversation

cumcke
Copy link
Collaborator

@cumcke cumcke commented Dec 9, 2023

No description provided.

gsmith-sas
gsmith-sas requested changes Dec 10, 2023
View reviewed changes
Copy link
Member

@gsmith-sas gsmith-sas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to make the datasource values w/in the JSON to make them "generic". See notes below.

monitoring/dashboards/viya/sas-arke-dashboard.json Outdated Show resolved Hide resolved
monitoring/dashboards/viya/sas-arke-dashboard.json Outdated Show resolved Hide resolved
cumcke
cumcke commented Dec 12, 2023
View reviewed changes
Copy link
Collaborator Author

@cumcke cumcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I know some of the existing references to the data source use "$datasource," but I think "Prometheus" should be fine.

@cumcke cumcke merged commit 54e4ae5 into main Dec 12, 2023
1 check passed
@cumcke cumcke deleted the sas-arke-dashboard branch December 12, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmith-sas gsmith-sas gsmith-sas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cumcke @gsmith-sas