Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (IAC-1484) Update IAC Sample Sizing #126

Merged
merged 11 commits into from
Jun 7, 2024
Merged

feat: (IAC-1484) Update IAC Sample Sizing #126

merged 11 commits into from
Jun 7, 2024

Conversation

jarpat
Copy link
Contributor

@jarpat jarpat commented Jun 5, 2024

Changes

Updated examples, defaults, and docs to line up with sizing recommendations.

Tests

Scenario Provider Example File kubernetes_version Order Cadence
1 OSS sample-terraform-dhcp.tfvars v1.28.7 ****** fast:2020
2 OSS sample-terraform-static-ips.tfvars v1.28.7
3 OSS sample-terraform-static-singlestore.tfvars v1.28.7
4 OSS sample-terraform-minimal.tfvars v1.28.7
5 OSS sample-terraform-minimal.tfvars v1.28.7
retest OSS sample-terraform-dhcp.tfvars v1.28.7 ****** fast:2020

@jarpat jarpat changed the title WIP feat: (IAC-1484) Update IAC Sample Sizing Jun 5, 2024
@jarpat jarpat marked this pull request as ready for review June 5, 2024 18:05
@jarpat jarpat self-assigned this Jun 5, 2024
@jarpat jarpat added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 5, 2024
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for clarification and possible code changes.

cpus = 16
memory = 131072
os_disk = 350
misc_disks = [
150,
150,
400,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful here. The 2 different disk are used for 2 different items. Though they look the same they are needed separately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll message you about this, there may be something about the misc_disks that I'm not aware of.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These misc disks are used by the static provisioner and not set asside for use with CASCACHE unless it uses the static provisioner to map that storage into the nodes.

cpus = 16
memory = 131072
cpus = 4
memory = 16384
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought compute needed 128G of memory to run items there. Interesting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's based off their testing and it also lines up with the SAS Doc that states 16 is the min for compute for a "SAS Viya" deployment
https://go.documentation.sas.com/doc/en/itopscdc/v_052/itopssr/n0ampbltwqgkjkn1j3qogztsbbu0.htm#n11a8r150qgkcon17txx5r526sd9

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it may be the min but if they are hoping for a more dynamic system on bare-metal or VMs this will not happen. So the resources needed for the compute need to be there from the very beginning.

examples/vsphere/sample-terraform-dhcp.tfvars Outdated Show resolved Hide resolved
examples/vsphere/sample-terraform-dhcp.tfvars Show resolved Hide resolved
cpus = 16
memory = 131072
os_disk = 350
misc_disks = [
150,
150,
400,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These misc disks are used by the static provisioner and not set asside for use with CASCACHE unless it uses the static provisioner to map that storage into the nodes.

cpus = 16
memory = 131072
cpus = 4
memory = 16384
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it may be the min but if they are hoping for a more dynamic system on bare-metal or VMs this will not happen. So the resources needed for the compute need to be there from the very beginning.

@jarpat
Copy link
Contributor Author

jarpat commented Jun 5, 2024

Summary of changes post-review comments:

  • Revert the misc_disks for cas
  • Revert compute's cpu/memory based back to the higher value
  • Revert the misc_disks for compute since I mistakenly confused it's purpose,
  • Keeping the changes to stateful, same amount of resources just split across two nodes now
  • Keeping changes to stateless, ends up being more resources just split across 4 nodes
  • Add singlestore back to the DHCP example

I'll need to do a quick test and I'll ask for another review afterwards.

@jarpat jarpat requested a review from thpang June 6, 2024 14:42
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as the number here reflect a real-world scenario and their maximum values where applicable given the static nature of bare-metal/vm deployments.

Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarpat jarpat merged commit 090818b into staging Jun 7, 2024
4 checks passed
@jarpat jarpat deleted the IAC-1484 branch June 7, 2024 19:23
@jarpat jarpat mentioned this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants