Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add annotation for external database (PSKD-407) #565

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

blchisholm
Copy link
Contributor

Changes:

This PR adds an annotation to deployments that are using an external postgres database. The presence of the annotation will gate behaviour of the data server operator.

Tests:

Verified following scenarios

Scenario Task Provider Cadence kubernetes_version Database Notes
1 OOTB Azure stable:2024.07 1.28 default: external Annotation appears in sasdeployment.yaml manifest
2 OOTB Azure stable:2024.07 1.29 default: internal Annotation does NOT appear in sasdeployment.yaml manifest

@blchisholm blchisholm added the enhancement New feature or request label Aug 2, 2024
Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blchisholm blchisholm merged commit b740636 into staging Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants