Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions config #2387

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Fix GitHub Actions config #2387

merged 5 commits into from
Oct 14, 2024

Conversation

jathak
Copy link
Member

@jathak jathak commented Oct 14, 2024

This updates our dependabot config to be compatible with new format restrictions and passes CHROME_DEVEL_SANDBOX when running browser tests to avoid a new sandbox that's incompatible with Ubuntu (see here)

@jathak jathak changed the title Fix dependabot configuration Fix GitHub Actions config Oct 14, 2024
@jathak jathak requested a review from nex3 October 14, 2024 21:14
- name: Run tests
run: dart run test -p chrome -j 2
env:
CHROME_EXECUTABLE: chrome
CHROME_DEVEL_SANDBOX: /opt/google/chrome/chrome-sandbox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link the relevant Chrome documentation here as well?

@jathak jathak merged commit f7b2e63 into main Oct 14, 2024
38 checks passed
@jathak jathak deleted the jathak-patch-1 branch October 14, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants