Code review/static analysis fixes

sass · Oct 11, 2024 · cd7631e · cd7631e
1 parent 23690dc
commit cd7631e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,7 +3,7 @@
 * Fix a bug where Sass would add an extra `*/` after loud comments with
   whitespace after an explicit `*/` in the indented syntax.
 
-* **Potentially breaking bug fxi:** Adding text after an explicit `*/` in the
+* **Potentially breaking bug fix:** Adding text after an explicit `*/` in the
   indented syntax is now an error, rather than silently generating invalid CSS.
 
 ## 1.79.5

diff --git a/lib/src/parse/sass.dart b/lib/src/parse/sass.dart
@@ -217,7 +217,6 @@ class SassParser extends StylesheetParser {
     scanner.expect("/*");
 
     var first = true;
-    var closed = false;
     var buffer = InterpolationBuffer()..write("/*");
     var parentIndentation = currentIndentation;
     while (true) {
@@ -264,25 +263,25 @@ class SassParser extends StylesheetParser {
 
               // For backwards compatibility, allow additional comments after
               // the initial comment is closed.
-                while (scanner.peekChar().isNewline && _peekIndentation() > parentIndentation) {
-                  while (_lookingAtDoubleNewline()) {
-                    _expectNewline();
-                  }
-                  _readIndentation();
-                  whitespace();
+              while (scanner.peekChar().isNewline &&
+                  _peekIndentation() > parentIndentation) {
+                while (_lookingAtDoubleNewline()) {
+                  _expectNewline();
                 }
+                _readIndentation();
+                whitespace();
+              }
 
               if (!scanner.peekChar().isNewline) {
                 var errorStart = scanner.state;
                 while (!scanner.isDone && !scanner.peekChar().isNewline) {
                   scanner.readChar();
                 }
-                throw new MultiSpanSassFormatException(
-                  "Unexpected text after end of comment",
-                  scanner.spanFrom(errorStart),
-                  "extra text",
-                  {span: "comment"}
-                );
+                throw MultiSpanSassFormatException(
+                    "Unexpected text after end of comment",
+                    scanner.spanFrom(errorStart),
+                    "extra text",
+                    {span: "comment"});
               } else {
                 return LoudComment(buffer.interpolation(span));
               }