Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Include Body settings not honored on fresh install #48

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: Include Body settings not honored on fresh install #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,12 @@ class _MyHomePageState extends State<MyHomePage> {
Future<bool> getSettings(String settingName,
{bool defaultValue = false}) async {
final SharedPreferences prefs = await SharedPreferences.getInstance();
return prefs.getBool(settingName) ?? defaultValue;
var retrievedValue = prefs.getBool(settingName);
if (retrievedValue == null) {
prefs.setBool(settingName, defaultValue);
return defaultValue;
}
return retrievedValue;
}

setSettings(String name, bool value) async {
Expand Down Expand Up @@ -260,7 +265,7 @@ class _MyHomePageState extends State<MyHomePage> {
var readable = readableResults["html"] as String;
var author = readableResults["author"] as String;
var excerpt = readableResults["excerpt"] as String;
var markdown = await getSettings("includeBody")
var markdown = await getSettings("includeBody", defaultValue: true)
? html2md.convert(readable, styleOptions: {
"headingStyle": "atx",
"hr": "---",
Expand Down