test(sanity): migrate sanity package to vitest #7578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: revamp eFPS suite * chore: add efps github actions * chore: use different token for efps tests * test: add comment with perf report result * test: keep playwright install script * feat: add workflow dispatch inputs * fix: use `requestAnimationFrame` instead --------- Co-authored-by: Binoy Patel <[email protected]>
* feat(sanity): allow `extractSchema` worker to emit schemas for all workspaces * feat(sanity): include workspace and dataset names when extracting schema * feat(cli): add `manifest` commands * feat(manifest): add `@sanity/manifest` package * refactor(sanity): use manifest schemas from `@sanity/manifest` * chore: format files * feat(schema): include `title`, `description`, and `deprecated` attributes when extracting schema * feat(sanity): add `direct` schema format to schema extractor * Revert "feat(schema): include `title`, `description`, and `deprecated` attributes when extracting schema" This reverts commit 60cb576. * feat(sanity): export `ConcreteRuleClass` class * feat(sanity): include validation rules in manifests * refactor(sanity): move manifest extraction code * feat(sanity): extract manifest during build * feat(sanity): adopt `.studioschema.json` filename suffix for manifest schemas * refactor(sanity): rename manifest extraction functions (remove plural) * fix(sanity): remove redundant success message * fix(sanity): stop build spinner before starting manifest extraction * feat(sanity): add `unstable_extractManifestOnBuild` CLI config option * feat(test-studio): enable `unstable_extractManifestOnBuild` * fix(sanity): switch to node crypto for node 18 compatibility * feat(cli): add `unstable_staticAssetsPath` CLI configuration option * chore(cli): refine `unstable_extractManifestOnBuild` CLI configuration option description * feat(sanity): remove extraneous `types` wrapper from manifests * debug(test-studio): remove Mux plugin to unblock typegen * feat(embedded-studio): enable manifest extraction * feat(starter-next-studio): enable manifest extraction * wip * feat(sanity): normalize type constraints in manifest validation * wip * chore: merge fix * feat: serialize userland properties and validation rules in manifest * fix: remove @sanity/manifest package * chore: cleanup * fix: serialize fieldsets * fix: omit default titles on fields and array-members * fix: ensure manifest schema is restoreble and supports cross dataset references * chore: mergefix * fix: serialization of type aliases no longer inlines fields and of props * fix: removes double dot in filename * feat: manifest command * chore: tweaks * chore: revert redundant changes * fix: adds manifest group to CLI * chore: wording change * fix: adds a 2-minute timeout to manifest extract * fix: ensures error code when mainfest extract fails and changes failed spinner message to info * chore: use *ENABLED instead of *DISABLED for constant * chore: defensive optional chaining for option extraction * chore: reworded EXTRACT_FAILURE_MESSAGE --------- Co-authored-by: Ash <[email protected]>
### Description <!-- What changes are introduced? Why are these changes introduced? What issue(s) does this solve? (with link, if possible) --> Updates the validate command to use studioHost configured in the CLI config instead of relying on the projects endpoint studioHost for this information. ### What to review <!-- What steps should the reviewer take in order to review? What parts/flows of the application/packages/tooling is affected? --> Changes makes sense ### Testing <!-- Did you add sufficient testing for this change? If not, please explain how you tested this change and why it was not possible/practical for writing an automated test --> Tests Updates ### Notes for release <!-- Engineers do not need to worry about the final copy, but they must provide the docs team with enough context on: * What changed * How does one use it (code snippets, etc) * Are there limitations we should be aware of If this is PR is a partial implementation of a feature and is not enabled by default or if this PR does not contain changes that needs mention in the release notes (tooling chores etc), please call this out explicitly by writing "Part of feature X" or "Not required" in this section. --> N/A (does not seem it is important to mention in release notes)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 3, 2024
|
No changes to documentation |
binoy14
changed the title
binoy14
force-pushed
the
test-migrate-repo
branch
from
a511081
to
1467824
Compare
binoy14
requested review from
ryanbonial and
bjoerge
and removed request for
a team
|
Component Testing Report Updated Oct 3, 2024 6:01 PM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Thu, 03 Oct 2024 18:05:20 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
|
@binoy14 The test pass, but I am seeing the addition of about 35 warnings about
|
Pretty sure they existed during jest as well but were getting swallowed by jest. Do you see any instances where it could be causing this? My suggestion is if other changes looks good we merge this and do a follow up PR that fixes the warnings |
ryanbonial
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates
sanitytests to vitestWhat to review
Changes makes sense and all tests pass
Testing
All tests should pass
Notes for release
N/A