Fixes #622: Valkyrie ID should equal string equivalent of ID to string

[josh-levinson]

Fixes Issue #622 (seems to be tagging the release, see: #662)

Valkyrie::ID#eql? and == should return true when a string is compared with an equivalent Valkyrie::ID

Added test to verify this behavior. The following examples should work per the example:

[11] pry(main)> id = Valkyrie::ID.new('abc')
=> #<Valkyrie::ID:0x007fdee25d4760 @id="abc">
[12] pry(main)> id.eql?('abc')
=> true
[13] pry(main)> id == 'abc'
=> true
[14] pry(main)> id == 'def'
=> false
[15] pry(main)> id == Valkyrie::ID.new('abc')
=> true

Following tests should pass: bundle exec rspec spec/valkyrie/types_spec.rb should verify this behavior.

Note: I just submitted my Individual Contributors License Agreement to Samvera Legal so not sure how long it takes to verify.

[tpendragon]

Can you just fix up the rubocop? rubocop -a should take care of it.

[josh-levinson]

Fixed per rubocop suggestions. Also fixed the test to do what is expected rather than just checking Valkyrie ID vs resource ID. But now tests resource ID vs actual string

[josh-levinson]

CLA has been approved and Robocop changes were made as requested.

[no-reply]

Confirming @jlevnhv's CLA.