Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow rails 6.1 #332

Merged
merged 2 commits into from
Jan 11, 2021
Merged

allow rails 6.1 #332

merged 2 commits into from
Jan 11, 2021

Conversation

jrochkind
Copy link
Contributor

This PR does nothing except change the gemspec to allow Rails 6.1. Curious if CI will pass like this?

I am unable to run tests locally per #331, so this is a way to see if CI will run tests for me to see what happens, sorry.

Closes #330

@jrochkind
Copy link
Contributor Author

Ah, circleci would have to be changed to actually run tests under rails 6.1 too.

I am not too familiar with circle-ci, but i'll see if I can figure it out.

@jrochkind
Copy link
Contributor Author

Rails 6.1 build seems to fail with:

Don't know how to build task 'webpacker:install' (See the list of available tasks with `rails --tasks`)

I'm not sure what's going on there, why webpacker:install wouldn't be available if it was really a rails 6.1 app (or even a rails 6.0 app) that engine cart was creating... so maybe it's not somehow? This is beyond the quick fix I was hoping for, so I guess it's demonstrated it needs more than just a gemspec change to work with rails 6.1.

I am also not sure how to control what jobs show up as "required" in github list above; some do some don't, the new 6.1 one does not.

@jrochkind
Copy link
Contributor Author

in my own app, if I fork qa to allow rails 6.1, and upgrade to rails 6.1.... my own apps tests pass, and it's functionality supported by qa works fine. I think it's possible this is just a test setup issue, and qa actually works fine with rails 6.1.

@jrochkind
Copy link
Contributor Author

Huh wait a seccond, rails 6-1 test is showing up green in github here.

And weird, when I click on it... it looks like it was passing in circleci?? Not sure why I swear I saw it failing before!

So... maybe qa passes tests fine on railas 6.1 and just needs a merge and release?

Copy link
Contributor

@elrayle elrayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@elrayle elrayle merged commit 6ef7587 into samvera:master Jan 11, 2021
@jrochkind jrochkind changed the title allow rails 6.2 allow rails 6.1 Jan 11, 2021
@jrochkind
Copy link
Contributor Author

jrochkind commented Jan 11, 2021

Thank you! And for quick release, that's so helpful, I appreciate it!

I corrected my typo in title of this PR, it allows rails 6.1, not 6.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Rails 6.1?
2 participants