Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtle background gradient on featured works #6893

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

kirkkwang
Copy link
Contributor

Summary

The gradient was throwing an invalid property value error which should be fixed now.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Take a look at the featured work when logged in as an admin user.
  • Notice that there is a very subtle gradient on the background

Type of change (for release notes)

  • notes-bugfix Bug Fixes

Before

image

After

image

@samvera/hyrax-code-reviewers

The gradient was throwing an invalid property value error which should
be fixed now.
@kirkkwang kirkkwang added the notes-bugfix Release Notes: Fixed a bug label Aug 16, 2024
Copy link

Test Results

    17 files  ±0      17 suites  ±0   2h 16m 58s ⏱️ +21s
 6 706 tests ±0   6 409 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 180 runs  ±0  12 785 ✅ ±0  395 💤 ±0  0 ❌ ±0 

Results for commit e9e360f. ± Comparison against base commit 69f0b81.

This pull request removes 273 and adds 273 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f2782cc21c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f8357405150>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f2782ce2588>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f835b17d0c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 88744f00-2673-43d6-a8bf-efafa5395752
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: cb866d41-6d87-437f-99af-1101ce781f8a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: b2b20d31-8376-418d-a189-d46a9fac4140
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: ccb398e0-6fdd-4589-80a0-faaef6085a03
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 3d638d81-f4b5-4c8f-8cab-5947edd776c1
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 5f17f912-b947-479a-8099-10c1b6f1bfd9
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa600e16ba0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fbb66620510>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa600ecc810>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fbb67a0b688>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: f6b2bfe9-dd6b-477e-acc6-a034a9a47fb0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 04ad0b32-9aa3-477e-8197-288039053a53
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a8a05b8b-81a5-403b-ae12-cc6f25998f9c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 770f12a4-5469-41ea-8a6c-01583f18dce5
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 10363ff6-3e3e-4a48-b581-1e259bf13006
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 5c715bee-2463-4d09-a0b7-b00b430fa445
…

@kirkkwang kirkkwang merged commit b02cd98 into main Aug 19, 2024
22 checks passed
@kirkkwang kirkkwang deleted the fix-gradient-background-on-featured-works-content branch August 19, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants