Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkyrie update #154

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
build:
docker:
# legacy needed for phantomjs
- image: circleci/ruby:2.5.1-node-browsers-legacy
- image: cimg/ruby:3.2.2-browsers
- image: circleci/redis:4
- image: ualbertalib/docker-fcrepo4:4.7
environment:
Expand Down Expand Up @@ -89,7 +89,7 @@ jobs:
- run:
name: Load config into SolrCloud
command: |
cd .internal_test_app/solr/config
cd .internal_test_app/solr/conf
zip -1 -r solr_hyrax_config.zip ./*
curl -H "Content-type:application/octet-stream" --data-binary @solr_hyrax_config.zip "http://localhost:8985/solr/admin/configs?action=UPLOAD&name=hyrax"
curl -H 'Content-type: application/json' http://localhost:8985/api/collections/ -d '{create: {name: hydra-test, config: hyrax, numShards: 1}}'
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ Gemfile.lock
# This is for @afred to keep scripts and docs for sprint demos.
# Please keep this here until we cut a 1.x release. Thanks!
demos/**/*
*.~undo-tree~
2 changes: 1 addition & 1 deletion app/controllers/hyrax/batch_ingest/batches_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def summary
def available_admin_sets
# Restrict available_admin_sets to only those current user can desposit to.
@available_admin_sets ||= Hyrax::Collections::PermissionsService.source_ids_for_deposit(ability: current_ability, source_type: 'admin_set').map do |admin_set_id|
[AdminSet.find(admin_set_id).title.first, admin_set_id]
[Hyrax.query_service.find_by(id: admin_set_id).title.first, admin_set_id.to_s]
end
end

Expand Down
1 change: 1 addition & 0 deletions app/jobs/hyrax/batch_ingest/batch_item_processing_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ class BatchItemProcessingJob < ApplicationJob
end

def perform(batch_item:)
# TODO Rob - does this work?
ingester_class = config(batch_item).ingester
ingester_options = config(batch_item).ingester_options
@work = ingester_class.new(batch_item, ingester_options).ingest
Expand Down
2 changes: 1 addition & 1 deletion app/models/hyrax/batch_ingest/batch.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def completed?

def admin_set
return unless admin_set_id
@admin_set ||= AdminSet.find(admin_set_id)
@admin_set ||= Hyrax.query_service.find_by(id: admin_set_id)
end

def collection
Expand Down
8 changes: 4 additions & 4 deletions hyrax-batch_ingest.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ Gem::Specification.new do |s|

s.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]

s.add_dependency 'rails', '~> 5.1.6'
s.add_dependency 'hyrax', '~> 2.2'
s.add_dependency 'roo', '~> 2.7.0'
s.add_dependency 'rails', '~> 6.0'
s.add_dependency 'hyrax', '>= 4.0', '< 6.0'
s.add_dependency 'roo', '~> 2.7'

s.add_development_dependency 'bixby'
s.add_development_dependency 'capybara'
Expand All @@ -28,7 +28,7 @@ Gem::Specification.new do |s|
s.add_development_dependency 'engine_cart', '~> 2.2'
s.add_development_dependency 'factory_bot_rails', '~> 4.11'
s.add_development_dependency 'fcrepo_wrapper'
s.add_development_dependency "sqlite3"
s.add_development_dependency "sqlite3", '~> 1.4'
s.add_development_dependency "rspec-rails", "~> 3.8"
s.add_development_dependency "rspec-collection_matchers"
s.add_development_dependency 'solr_wrapper', '~> 2.1'
Expand Down
1 change: 1 addition & 0 deletions lib/hyrax/batch_ingest.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# frozen_string_literal: true
require "hyrax/batch_ingest/version"
require "hyrax/batch_ingest/engine"
require 'hyrax/batch_ingest/config'
require 'hyrax'
Expand Down
2 changes: 1 addition & 1 deletion lib/hyrax/batch_ingest/version.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true
module Hyrax
module BatchIngest
VERSION = '0.2.0'
VERSION = '0.2.0b'
end
end