Add Range codec (Update CRAM Codecs to CRAM 3.1) #1644
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-puligundla
force-pushed
the
yp_cram_3_1_range_codec
branch
from
5dad675
to
c06f952
Compare
yash-puligundla
force-pushed
the
yp_cram_3_1_range_codec
branch
3 times, most recently
from
9a1f9fd
to
85cc94d
Compare
This was referenced Mar 21, 2023
…dded in the streams).
yash-puligundla
force-pushed
the
yp_cram_3_1_range_codec
branch
from
7e220fb
to
a4b2837
Compare
cmnbroad
requested changes
Nov 21, 2023
src/main/java/htsjdk/samtools/cram/compression/range/RangeCoder.java
Outdated
Show resolved
Hide resolved
src/main/java/htsjdk/samtools/cram/compression/range/RangeCoder.java
Outdated
Show resolved
Hide resolved
src/main/java/htsjdk/samtools/cram/compression/range/ByteModel.java
Outdated
Show resolved
Hide resolved
src/main/java/htsjdk/samtools/cram/compression/range/ByteModel.java
Outdated
Show resolved
Hide resolved
cmnbroad
reviewed
Nov 28, 2023
src/main/java/htsjdk/samtools/cram/compression/range/RangeDecode.java
Outdated
Show resolved
Hide resolved
src/main/java/htsjdk/samtools/cram/compression/range/RangeDecode.java
Outdated
Show resolved
Hide resolved
src/main/java/htsjdk/samtools/cram/compression/range/RangeDecode.java
Outdated
Show resolved
Hide resolved
src/main/java/htsjdk/samtools/cram/compression/range/RangeDecode.java
Outdated
Show resolved
Hide resolved
src/main/java/htsjdk/samtools/cram/compression/range/RangeCoder.java
Outdated
Show resolved
Hide resolved
src/main/java/htsjdk/samtools/cram/compression/range/RangeDecode.java
Outdated
Show resolved
Hide resolved
src/main/java/htsjdk/samtools/cram/compression/range/RangeDecode.java
Outdated
Show resolved
Hide resolved
src/main/java/htsjdk/samtools/cram/compression/range/RangeDecode.java
Outdated
Show resolved
Hide resolved
added 7 commits
December 1, 2023 15:47
yash-puligundla
force-pushed
the
yp_cram_3_1_range_codec
branch
from
a4b2837
to
2ac2b83
Compare
added 12 commits
January 10, 2024 14:22
… stripe, nosize, cat flags
yash-puligundla
force-pushed
the
yp_cram_3_1_range_codec
branch
from
4375f88
to
f9b066c
Compare
|
@cmnbroad I have addressed all the comments from this round of feedback. This PR is ready for review. Let me know if you have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is in draft as it is dependent on RANS NX16 PR
Description
This PR is part of an effort to upgrade CRAM to v3.1. It adds the Range Codec implementation.
List of Changes:
Add Range Codec
Add RangeTest to unittest the Range Codec implementation
Add RangeInteropTest to test the Range Codec using the test files from htscodecs. These interop tests use the files from samtools installation (samtools-1.14/htslib-1.14/htscodes/tests/dat)