update deps, enable VarConstantCommentRector

samsonasik · Feb 5, 2022 · 87807bd · 87807bd
1 parent 1bd0fa5
commit 87807bd
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 8 deletions.
diff --git a/composer.json b/composer.json
@@ -33,14 +33,17 @@
     },
     "require-dev": {
         "guzzlehttp/guzzle": "^7.2",
-        "kahlan/kahlan": "dev-moving-to-github-action",
+        "kahlan/kahlan": "^5.2",
         "laminas/laminas-coding-standard": "^2.1.1",
         "php-coveralls/php-coveralls": "^2.4",
         "phpstan/phpstan": "^1.0",
         "rector/rector": "dev-main"
     },
     "config": {
-        "bin-dir": "bin"
+        "bin-dir": "bin",
+        "allow-plugins": {
+            "dealerdirect/phpcodesniffer-composer-installer": true
+        }
     },
     "extra": {
         "zf": {

diff --git a/rector.php b/rector.php
@@ -1,8 +1,6 @@
 <?php
 
-use Rector\CodingStyle\Rector\ClassConst\VarConstantCommentRector;
 use Rector\Core\Configuration\Option;
-use Rector\Core\ValueObject\PhpVersion;
 use Rector\Set\ValueObject\LevelSetList;
 use Rector\Set\ValueObject\SetList;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
@@ -21,8 +19,4 @@
     $parameters->set(Option::PATHS, [__DIR__ . '/config', __DIR__ . '/src', __DIR__ . '/spec']);
 
     $parameters->set(Option::AUTO_IMPORT_NAMES, true);
-
-    $parameters->set(Option::SKIP, [
-        VarConstantCommentRector::class,
-    ]);
 };
diff --git a/src/Error/SpecialErrorMessage.php b/src/Error/SpecialErrorMessage.php
@@ -12,18 +12,27 @@
  */
 final class SpecialErrorMessage
 {
+    /**
+     * @var array<string, int|string>
+     */
     public const RESOURCE_NOT_AVAILABLE = [
         'code'   => 410,
         'reason' => 'API Call failed, The target resource %s is no longer available, '
             . 'please check your ApigilityConsumer config, '
             . 'and/or ask API service administrator whether the API server is down.',
     ];
 
+    /**
+     * @var array<string, int|string>
+     */
     public const INVALID_REQUEST_FILE = [
         'code'   => 400,
         'reason' => 'Invalid files data, please make sure you have "tmp_name" and "name" key',
     ];
 
+    /**
+     * @var array<string, int|string>
+     */
     public const SERVICE_UNAVAILABLE = [
         'code'   => 503,
         'reason' => 'Service Unavailable, please contact API service administrator.',