-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build/push arm64 container images #180
base: master
Are you sure you want to change the base?
build/push arm64 container images #180
Conversation
9343f64
to
dad4ff9
Compare
@phlogistonjohn do you have time to look into this topic? It would be nice to see if the pipeline is running with my changes. |
I am currently traveling and dont have a lot of time too look, but I will allow the CI jobs to run! |
dad4ff9
to
c4a4073
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution!
This looks like a good addition.
Siome CI checks have failed, please fix.
Especially the check-commits test. (no commit message body provided).
c4a4073
to
9a92ce3
Compare
When Docker is used and the target architecture differs from the host architecture, use buildx for cross-building. Signed-off-by: Alexander Bachmann <[email protected]>
Extend the arch matrix parameter to enable arm64 builds for the server, ad-server, client, toolbox and test-server images. Signed-off-by: Alexander Bachmann <[email protected]>
7795ca5
to
bd8e932
Compare
Things are getting a bit more interesting now. The
It’s also possible to set the arch parameter to source. This will increase the build time, but we could add a check: if the target architecture is not supported, then fall back to source. This way, the amd64 builds won’t be affected. I checked the list of available repositories and their architecture support. A lot of them support aarch64, but not the resilientstorage repositories. So, if we start building the packages from source, we might run into issues. Before I proceed, I’d like to get your thoughts on this. Maybe you're already aware of the issue and have some solutions in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding commit message bodies, @abachmann !
If you want to squash the two commits that change the workflows, go ahead. I don't have a strong opinion on that part as long as the change that modifies the script remains a separate commit.
I didn't quite understand yet what makes it necessary to remove the explicit invocation of the arch from the workflows. I do prefer we keep testing arm builds in the ci.
some ci checks are still failing. please address.
@abachmann, any updates here? We'd really like to take the changes, but please address the requests. |
bd8e932
to
b78b782
Compare
@obnoxxx, sorry for the late response. I was busy with other things.
Yeah, I initially thought the explicit invocation of the arch was causing the pipeline issue, but it turned out that wasn’t the case. So, I reverted the commit. As I wrote in my last comment:
Addressing the pipeline issue isn't so easy. I'll try to find some time over the weekend to fix it. |
@abachmann wrote:
sure. Thanks for following up! And sorry for nagging so badly!
Thanks for explaining. This makes more sense now.
right. The centos repo mirrors do sometimes have issues with availability.
Interesting.
Thanks! Looking forward to seeing a solution. |
Extends the GA workflow to build and push ARM64 container images. The
build-image
script has been modified to use Docker Buildx for cross-building.Preparation for: #179
Fixes: #155