Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing node constants export #443

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

thantos
Copy link
Contributor

@thantos thantos commented Sep 11, 2023

Debugging typescript performance issues in another project.

Typescript started to pull in ../eventual/* files from across my file system. This seems to be because ./constants/index.js (@eventual/core/contstants) did not actually exist in @eventual/core because it wasn't included in the node files.

My system seems to resolve it to my local, but I am unsure what it is doing on other systems. When the file is included from local, typescript started to pull other core files from my local eventual repo too (see below).

  • Added constants to files in package.json to match the internal path.

(via tsc --explainFiles)

../eventual/packages/@eventual/core/lib/cjs/http/command-rpc-path.d.ts
  Imported via "./http/command-rpc-path.js" from file '../eventual/packages/@eventual/core/lib/cjs/constants.d.ts'
../eventual/packages/@eventual/core/lib/cjs/constants.d.ts
  Imported via "../lib/cjs/constants.js" from file '../eventual/packages/@eventual/core/constants/index.d.ts'
../eventual/packages/@eventual/core/constants/index.d.ts
  Imported via "@eventual/core/constants" from file 'node_modules/.pnpm/@[email protected]/node_modules/@eventual/client/lib/cjs/base-http-client.d.ts' with packageId '@eventual/core/constants/[email protected]'

@thantos thantos merged commit f9c4ecf into main Sep 11, 2023
3 checks passed
@thantos thantos deleted the sussman/fix/missing_node_export branch September 11, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants