Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to cache by album #512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

dsschult
Copy link
Contributor

Add an option to do extended caching by album, instead of globally for the whole gallery.

This compliments #511 by not needing to load and save a huge pickle file every time, saving multiple seconds in my case. Only the album that gets updated has it's cache loaded and saved.

By default the old mode (global) is used, so it is opt-in.

I also made some variable names more consistent (removing camel case), since I was editing most of the file.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (27e10d4) 88.72% compared to head (2b2d6e0) 89.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
+ Coverage   88.72%   89.40%   +0.68%     
==========================================
  Files          25       25              
  Lines        2066     2096      +30     
==========================================
+ Hits         1833     1874      +41     
+ Misses        233      222      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant