[components-webview] Create screen resolution to layout.css.devPixelsPerPx mapping. JB#62599 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could theoretically got to master but I don't see us doing releases from there. So, this should be as good. |
|
For reference this 1080x2520 => 2.608695652173913 has been taken from the same device running Android FF. |
pvuorela
reviewed
Oct 7, 2024
…PerPx mapping. JB#62599 This is rather simple way to map these. At the same, there ain't that many screen resolution that we'd like to map. Thus, this approach is reasoble for our needs. For testing this, if you have ran browser at least once, you need to remove __PREFS_WRITTEN__ flag file from your device. > rm $HOME/.local/share/org.sailfishos/browser/__PREFS_WRITTEN__ GitHub issue: sailfishos/sailfish-browser#1085
|
Said resolution being in xperia 10 series they appear to have ppi of 457 (10V 449, not that far). If the non-rounded css pixel ratios are ok, pondering should we just on all(?) the devices compare the device ppi to 175. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rather simple way to map these. At the same, there ain't that many screen resolution that we'd like to map. Thus, this approach is reasoble for our needs.
For testing this, if you have ran browser at least once, you need to remove PREFS_WRITTEN flag file from your device.