[openssl] Use mainline ECC code and drop fips patches. Fixes JB#54628 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thaodan
reviewed
Jun 21, 2021
| # The hobble_openssl is called here redundantly, just to be sure. | ||
| # The tarball has already the sources removed. | ||
| sh %{SOURCE1} > /dev/null | ||
|
|
There was a problem hiding this comment.
To use code from original ec_curve.c
|
You should document the changes and not just remove the lines. |
|
Hi, did a quick look and it seems that this patch contains:
Still need to do more detailed review, but would be better if this would be in 4 parts and having reasonings for all of those. In the commit message it is not clear which parts of the commit are done for which reasoning. Best would be to have all as separate commits, but at minimum would have some explanation why each thing was done to understand better what is aimed with all of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.