WIP: [rpm] After fixing scratchbox the libclang workaround is not required anymore. JB#55042 #150
Conversation
|
Does sailfishos/scratchbox2#21 also fix the "#include_next" issue, or was this fixed elsewhere already? |
It does indeed fix that too. In fact it's required to remove that workaround, otherwise there'll be build issues. |
|
Okay, nice. This change looks fine to me, but I guess I should do at least one complete local build just to be sure, before hitting Accept. |
You'll need to install scratchbox2 and libsb2 from the other pr in the sdk. As well as libsb2 in the tooling. |
… anymore. JB#59836 We still need to specify the path for it though, since configure picks it off of LD_LIBRARY_PATH which has the sb2 tooling path in it.
It's a bit weird, sometimes i do get an error due to include_next, sometimes not. It also seems to be happening when the workaround is applied sometimes though? In other words: do not merge yet :) |
|
It never fully worked unfortunately. Will close for now. |
We still need to specify the path for it though, since configure picks it off of LD_LIBRARY_PATH which has the sb2 tooling path in it.
DO NOT MERGE BEFORE:
sailfishos/scratchbox2#21