rtnl: Add ARPHRD_PUREIP netdev type. #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connman/src/rtnl.c
Outdated
| @@ -51,6 +51,10 @@ | |||
| #define ARPHRD_RAWIP_1 (519) /* Vanilla kernel */ | |||
| #define ARPHRD_RAWIP_2 (530) /* Some android kernels */ | |||
|
|
|||
| /* ARPHRD_PUREIP has been introduced in some MTK kernels (in intention to | |||
| * get rid of link local address creation for the ccmni net devices) */ | |||
There was a problem hiding this comment.
Untrue, well, maybe for MTK but in general reason was this https://lkml.org/lkml/2021/6/24/76 and the solution is not really accepted into kernels as of https://lkml.kernel.org/netdev/[email protected]/
Not yet sure if this is to be included. Upstream might criticize this for sure.
And, multi line comments are formatted (coding-style.txt M2):
/*
* Line1.
* Line2.
*/
There was a problem hiding this comment.
Comment section fixed.
It is possible for me to roll current MTK kernel's ccmni interface netdev type back to ARPHRD_PPP as long as it will not lead to any kind of issues (presumably).
But still, I'll leave this PR as a suggestion because there are no guarantees that ARPHRD_PUREIP will not be used in the future MTK projects.
Since ARPHRD_PUREIP netdev type has been introduced in kernel on some of the MTK-based devices, there have been issues caused by the subject. This netdev type needs to be handled by ipconfig module, so this commit adds the support of the ARPHRD_PUREIP by handling appropriate ntelink events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
ARPHRD_PUREIPnetdev type has been introduced in kernel on some ofthe MTK-based devices, there have been issues caused by the subject.
This netdev type needs to be handled by
ipconfigmodule, so this commitadds the support of the
ARPHRD_PUREIPby handling appropriate ntelinkevents.