chore: Apache NiFi and Zookeepr minor version bumps

[saidsef]

• chore: Apache NiFi and Zookeepr minor version bumps

[saidsef]

/code pr

[saidsef]

🤖
Review of PR: chore: Apache NiFi and Zookeeper minor version bumps

File: deployment/nifi/nifi.yml

• Line 67: Updated Apache NiFi image version from 1.24.0 to 1.25.0. This change seems appropriate for a minor version bump. Ensure compatibility with existing configurations and dependencies.

File: deployment/zookeeper/zookeeper.yml

• Line 37: Updated Zookeeper image version from 3.8 to 3.9. Similar to the NiFi update, ensure this version bump does not introduce any breaking changes or require configuration adjustments.

General Comments:

• Both changes are minor version updates, which typically include bug fixes and improvements without breaking changes. However, it's crucial to verify these assumptions through testing or reviewing release notes.
• Ensure that any dependent services or configurations that interact with NiFi and Zookeeper are compatible with these new versions.
• Consider adding a brief description of the reason for these updates in the commit message, such as addressing specific issues or leveraging new features.

Overall, the PR is straightforward and appears to follow best practices for minor version updates. Pending validation of compatibility and successful testing, it looks ready to merge.

_{> gpt-4-turbo-preview [pr | 1]}

[saidsef]

/code pr

[saidsef]

🤖

Patch 1/3: Apache NiFi and Zookeeper minor version bumps

deployment/nifi/nifi.yml

• Updated Apache NiFi image version to 1.25.0. No issues or suggestions.

deployment/zookeeper/zookeeper.yml

• Updated Zookeeper image version to 3.9. No issues or suggestions.

Patch 2/3: Update CI workflow to trigger off deployment folder modified

.github/workflows/ci.yml

• Modified trigger paths to include all nested files and directories within deployment/ by changing from deployment/* to deployment/**. This is a good improvement ensuring that any changes within the deployment directory, regardless of depth, will trigger the workflow.

Patch 3/3: Remove upload of files to release

.github/workflows/release.yml

• Removed the block of code responsible for uploading Kubernetes YAML files to GitHub releases. This decision, as mentioned in the commit message, is based on the redundancy of uploading these files when a GitHub tag and release are created. This simplification could streamline the release process, assuming that the YAML files are not needed by end-users directly from the release assets.

No further issues or suggestions for this patch.

_{> gpt-4-turbo-preview [pr | 0]}