Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of vialrgb #47

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

Implementation of vialrgb #47

wants to merge 33 commits into from

Conversation

PercyJW-2
Copy link
Contributor

@PercyJW-2 PercyJW-2 commented Aug 15, 2024

I have implemented hid communication needed to control rgb via vial. I don't know if this is clean enough to merge, but I have a working keyboard implementation at this repository.
Moreover, I maybe don't have enough time to bring the implementation up to a mergable standard but still want to provide at least inspiration for a proper implementation

@PercyJW-2
Copy link
Contributor Author

Also, there is a problem with the usage of the machine package, and don´t quite know how to fix this

@sago35
Copy link
Owner

sago35 commented Aug 17, 2024

@PercyJW-2
I'm very grateful for the work on VialRGB support. I'm looking forward to it.
Please clean up the Git history and remove any unnecessary changes. Typically, you can do this by performing a rebase once and then removing unnecessary changes like those in .gitignore.

$ git checkout main
$ git checkout -b vialrgb-work
$ git reset --soft sago35/main
$ git commit

image

@sago35
Copy link
Owner

sago35 commented Aug 17, 2024

Additionally, there is no need to modify go.mod for this PR. Please revert any changes made to it. If not modifying it results in any errors, please let me know. We can work together to find a solution.

@PercyJW-2
Copy link
Contributor Author

PercyJW-2 commented Aug 17, 2024 via email

rgb.go Show resolved Hide resolved
@PercyJW-2
Copy link
Contributor Author

Nice, it seems like, that that did the job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants