Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vue-sortable.js #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update vue-sortable.js #13

wants to merge 1 commit into from

Conversation

wormen
Copy link

@wormen wormen commented Oct 7, 2016

update described in #10

@jefflam
Copy link

jefflam commented Oct 17, 2016

@wormen This PR works for making Sortable work with Vue 2.0.. any idea why the checks are failing?

@sagalbot
Copy link
Owner

The checks fail because you can longer access the vm from the directive. That means that from the vm, you don't have a way to access the sortable instance, so all of the tests around assigning an ID fail.

I'm almost done a 2.0 compatible version which uses this inplementation for the directive, which can be used for simple situations, where you don't need to access the sortable instance from the vm. It will also include a sortable component that you may use when you need a more flexible implementation.

@MunGell MunGell mentioned this pull request Oct 17, 2016
@haugen86
Copy link

haugen86 commented Nov 7, 2016

Any closer to releasing the 2.0 compatible version, Sir? :-)

@alan-andrade
Copy link

I understand @sagalbot is working on v2.0 compatible. Does that mean this pr would get resolved as part of that work ? If not, what can we do to move this PR forward ?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants