Show bank account details on invoices #1908
Open
+166
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keshavbiswa
reviewed
Sep 23, 2024
Comment on lines
+180
to
+182
| def bank_account_details | ||
| company.bank_account | ||
| end |
There was a problem hiding this comment.
This method is not needed.
Comment on lines
+3
to
+10
| if bank_account.present? | ||
| json.bank_name bank_account.bank_name | ||
| json.account_type bank_account.account_type.capitalize | ||
| json.routing_number bank_account.routing_number | ||
| json.account_number bank_account.account_number | ||
| else | ||
| json.null! | ||
| end |
There was a problem hiding this comment.
I don't think this condition is needed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1890
TODO