Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rails to 7.2 #1888

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ require:
- rubocop-performance
- rubocop-rails
- rubocop-rspec
- rubocop-rspec_rails
- rubocop-factory_bot

AllCops:
TargetRubyVersion: 3.1.2
Expand Down Expand Up @@ -602,10 +604,10 @@ RSpec/ExpectInHook:
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectInHook

RSpec/FilePath:
Rails/FilePath:
Description: Checks that spec file paths are consistent and well-formed.
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FilePath
StyleGuide: https://www.rubydoc.info/gems/rubocop-rails/RuboCop/Cop/Rails/FilePath

RSpec/HookArgument:
Description: Checks the arguments passed to before, around, and after.
Expand Down Expand Up @@ -739,29 +741,21 @@ RSpec/Rails/AvoidSetupHook:
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/AvoidSetupHook

RSpec/Rails/HttpStatus:
Rails/HttpStatus:
Description:
Enforces use of symbolic or numeric value to describe HTTP status.
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HttpStatus
StyleGuide: https://www.rubydoc.info/gems/rubocop-rails/RuboCop/Cop/Rails/HttpStatus

# RSpec x FactoryBot
RSpec/FactoryBot/AttributeDefinedStatically:
Description: Always declare attribute values as blocks.
FactoryBot/AttributeDefinedStatically:
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/AttributeDefinedStatically

RSpec/FactoryBot/CreateList:
Description: Checks for create_list usage.
FactoryBot/CreateList:
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/CreateList

RSpec/FactoryBot/FactoryClassName:
Description: Use string value when setting the class attribute explicitly.
FactoryBot/FactoryClassName:
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/FactoryClassName

RSpec/FactoryBot/SyntaxMethods:
Description: Use shorthands from FactoryBot::Syntax::Methods in your specs.
FactoryBot/SyntaxMethods:
Enabled: true
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/SyntaxMethods
5 changes: 4 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
ruby "3.2.4"

# Bundle edge Rails instead: gem "rails", github: "rails/rails", branch: "main"
gem "rails", "~> 7.1.3"
gem "rails", "~> 7.2.0"

# Use postgresql as the database for Active Record
gem "pg"
Expand Down Expand Up @@ -165,6 +165,9 @@ group :development, :test, :ci do
# Use factory-bot to replace fixtures
gem "factory_bot_rails"

gem "rubocop-factory_bot"
gem "rubocop-rspec_rails"

# Use Faker for fake data
gem "faker"

Expand Down
Loading
Loading