Remove redis #1879
Closed
Remove redis #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+14
to
+20
| BulkInvoiceDownloadJob.perform_now( | ||
| invoice_ids, | ||
| company_logo, | ||
| download_id, | ||
| root_url, | ||
| current_url_options | ||
| ) |
There was a problem hiding this comment.
Instead of calling the Job, can you copy all the contents from the job and do a benchmarking.
There was a problem hiding this comment.
I did that and the results are same. Very minor difference. Should I go ahead and delete this file and uninstall redis?
|
Instead of this, could we exploring removing BulkInvoiceDownloadChannel instead if possible? We could remove ACa completely. If not, then we should explore anycable or using hotwire if possible, or just simple polling. |
|
@apoorv1316 what's the status on this? Can we wrap this up before picking up other issues? |
|
Closing this in favor of #1892 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.